Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 83BB010E6C for ; Mon, 14 Sep 2015 18:01:05 +0000 (UTC) Received: (qmail 88424 invoked by uid 500); 14 Sep 2015 17:57:37 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 88380 invoked by uid 500); 14 Sep 2015 17:57:37 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 88134 invoked by uid 99); 14 Sep 2015 17:57:37 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Sep 2015 17:57:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E2F9CF22C2 for ; Mon, 14 Sep 2015 17:57:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.991 X-Spam-Level: X-Spam-Status: No, score=0.991 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id r5podhraSfby for ; Mon, 14 Sep 2015 17:57:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 5628C206EE for ; Mon, 14 Sep 2015 17:57:21 +0000 (UTC) Received: (qmail 62770 invoked by uid 99); 14 Sep 2015 17:47:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Sep 2015 17:47:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 19614DFCE4; Mon, 14 Sep 2015 17:47:52 +0000 (UTC) From: sjcorbett To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: Mongodb authentication Content-Type: text/plain Message-Id: <20150914174752.19614DFCE4@git1-us-west.apache.org> Date: Mon, 14 Sep 2015 17:47:52 +0000 (UTC) Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/incubator-brooklyn/pull/894#discussion_r39423716 --- Diff: software/nosql/src/main/java/org/apache/brooklyn/entity/nosql/mongodb/sharding/CoLocatedMongoDBRouterImpl.java --- @@ -19,32 +19,47 @@ package org.apache.brooklyn.entity.nosql.mongodb.sharding; import java.util.Collection; +import java.util.concurrent.ExecutionException; import org.apache.brooklyn.api.entity.EntitySpec; import org.apache.brooklyn.api.location.Location; +import org.apache.brooklyn.api.mgmt.Task; import org.apache.brooklyn.core.entity.Entities; import org.apache.brooklyn.core.entity.trait.Startable; import org.apache.brooklyn.core.sensor.DependentConfiguration; import org.apache.brooklyn.enricher.stock.Enrichers; +import org.apache.brooklyn.entity.group.AbstractGroup; +import org.apache.brooklyn.entity.nosql.mongodb.MongoDBAuthenticationMixins; +import org.apache.brooklyn.entity.nosql.mongodb.MongoDBAuthenticationUtils; import org.apache.brooklyn.entity.software.base.SameServerEntityImpl; +import org.apache.brooklyn.util.exceptions.Exceptions; import com.google.common.base.Predicates; import com.google.common.collect.Iterables; -public class CoLocatedMongoDBRouterImpl extends SameServerEntityImpl implements CoLocatedMongoDBRouter { +public class CoLocatedMongoDBRouterImpl extends SameServerEntityImpl implements CoLocatedMongoDBRouter, MongoDBAuthenticationMixins { + + private MongoDBRouter router; --- End diff -- This won't persist well. Suggest a `getRouter()` method which just looks for `Entities.descendants(this, MongoDBRouter.class)`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---