brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From grkvlt <>
Subject [GitHub] incubator-brooklyn pull request: Fixing JcloudsLocationSecurityGro...
Date Wed, 16 Sep 2015 03:23:31 GMT
GitHub user grkvlt opened a pull request:

    Fixing JcloudsLocationSecurityGroupCustomizer on OpenStack

    Add synchronization and checks for duplicate rules in addPermission for the `JcloudsLocationSecurityGroupCustomizer`
as used by Clocker. When deploying to OpenStack, duplicate rules will cause the `addPermission`
method to fail, if the customizer is called in parallel on the same group. So, we serialize
the calls with a `synchronized` block, and inside the critical section we make sure to only
add rules that are not already present.

You can merge this pull request into a Git repository by running:

    $ git pull fix/openstack-security-group-customizer

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #901
commit 4096358f5fcc3058f8185d2587086d93fb023c9a
Author: Andrew Kennedy <>
Date:   2015-09-16T03:11:06Z

    Add synchronization and checks for duplicate rules in addPermission security group customizer


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message