brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Config constraints
Date Wed, 30 Sep 2015 13:03:59 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/890#discussion_r40790160
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalEntityManager.java
---
    @@ -268,9 +270,26 @@ public void manage(Entity e) {
                         new Exception("source of duplicate management of "+e));
                 return;
             }
    +        // Validate all config before attempting to manage any entity. Do this here rather
    +        // than in manageRecursive so that rebind is unaffected.
    +        validateDescendantConfig(e);
    --- End diff --
    
    What's the reason to do it here rather than in `InternalEntityFactory` (analogously to
the policy path)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message