brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hzbarcea <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Regex replacement dsl
Date Thu, 24 Sep 2015 11:02:28 GMT
Github user hzbarcea commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/910#discussion_r40307170
  
    --- Diff: core/src/main/java/org/apache/brooklyn/enricher/stock/Transformer.java ---
    @@ -44,9 +44,6 @@
         public static ConfigKey<Function<?, ?>> TRANSFORMATION_FROM_VALUE = ConfigKeys.newConfigKey(new
TypeToken<Function<?, ?>>() {}, "enricher.transformation");
         public static ConfigKey<Function<?, ?>> TRANSFORMATION_FROM_EVENT = ConfigKeys.newConfigKey(new
TypeToken<Function<?, ?>>() {}, "enricher.transformation.fromevent");
         
    -    public Transformer() {
    --- End diff --
    
    I went back and forth for year on the implicit vs explicit argument. An argument would
be that if it's there with no value, one may infer that there was an intention to do something
but then the developer forgot. One convention made in other projects is to add a comment in
the empty block that says something like "intentionally left blank". This applies even more
to empty catch() blocks. My $0.02.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message