brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Uses BrooklynAccessUtils.getBrook...
Date Fri, 18 Sep 2015 12:11:29 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/898#issuecomment-141432410
  
    @nakomis I agree with @sjcorbett - if we change the `DATASTORE_URL` meaning to be a potentially
NAT'ed ip:port, then that can mean it's not accessible from other VMs within the same private
network / zone.
    
    We should be consistent with other types of entity, such as app servers. There the `webapp.url`
and `main.uri` are constructed using the `getSubnetHostname()` and unmapped port.
    
    If we want to change the semantics of `DATASTORE_URL` (and all other external endpoints
sensors), then we should not do that lightly - it would need to be discussed on the mailing
list. Personally, I'd be in favour of leaving this as the VM's url, and then having a mapped
version of the sensor where required for external use.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message