brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Capture exit code in AbstractSoft...
Date Fri, 18 Sep 2015 09:30:35 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/
    @@ -154,11 +214,11 @@ protected WinRmToolResponse executeCommand(ConfigKey<String>
             Task<?> currentTask = Tasks.current();
             if (currentTask != null) {
                 writeToStream(stdIn, Strings.isBlank(regularCommand) ? powershellCommand
: regularCommand);
    -            Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDIN,
    +            Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDIN,
stdIn)); flags.put("stdin", stdIn);
                 if (, BrooklynTaskTags.STREAM_STDOUT)==null)
    -                Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDOUT,
    -                Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDERR,
    +                Tasks.addTagDynamically(BrooklynTaskTags.tagForStreamSoft(BrooklynTaskTags.STREAM_STDOUT,
stdOut)); flags.put("stdout", stdOut);
    --- End diff --
    Can you separate these commands onto multiple lines - it risks being missed by someone
reading the code when at the end of a long line like this. Same for the code above.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message