brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Capture exit code in AbstractSoft...
Date Fri, 18 Sep 2015 08:24:29 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/906#discussion_r39833499
  
    --- Diff: core/src/main/java/org/apache/brooklyn/location/winrm/WinRmMachineLocation.java
---
    @@ -18,32 +18,6 @@
      */
     package org.apache.brooklyn.location.winrm;
     
    -import static com.google.common.base.Preconditions.checkNotNull;
    --- End diff --
    
    I prefer not having changes that just re-order imports.
    
    Also, the vast majority of our code uses the Eclipse convention for ordering imports (this
looks like the Intellij default). I believe that (some) Intellij users change their settings
to use the Eclipse ordering, for Brooklyn.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message