brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix for BROOKLYN-169 - CreateUser...
Date Fri, 11 Sep 2015 17:10:31 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/877#discussion_r39293085
  
    --- Diff: locations/jclouds/src/test/java/org/apache/brooklyn/policy/jclouds/os/CreateUserPolicyLiveTest.java
---
    @@ -73,6 +73,7 @@ public void runTestCreatesUser(MachineProvisioningLocation<SshMachineLocation>
l
                 app.createAndManageChild(EntitySpec.create(TestEntity.class)
                         .policy(PolicySpec.create(CreateUserPolicy.class)
                                 .configure(CreateUserPolicy.GRANT_SUDO, true)
    +                            .configure(CreateUserPolicy.RESET_LOGIN_USER, true)
    --- End diff --
    
    Why use `RESET_LOGIN_USER=true` here? If anyone were to run `testIntegrationCreatesUser()`,
it would reset their user password! We should either delete `testIntegrationCreatesUser()`,
or remove this (to rely on the default of false).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message