brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Misc fixes working with plans
Date Fri, 11 Sep 2015 17:01:28 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/887#discussion_r39292183
  
    --- Diff: utils/common/src/test/java/org/apache/brooklyn/util/time/TimeTest.java ---
    @@ -152,7 +152,13 @@ public void testElapsedSince() {
             Assert.assertFalse(Time.hasElapsedSince(aFewSecondsAgo, Duration.TEN_SECONDS));
             Assert.assertTrue(Time.hasElapsedSince(-1, Duration.TEN_SECONDS));
         }
    -    
    +
    +    @Test
    +    public void testParseTime() {
    +        Assert.assertEquals(Time.parseElapsedTime("1s"), 1000);
    --- End diff --
    
    There's a lot of logic in `parseElapsedTimeAsDouble`. Would be good to test more scenarios,
e.g. the inverse of of the tests in `testMakeStringExact_secondsAndMillis()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message