brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Misc fixes working with plans
Date Fri, 11 Sep 2015 16:48:08 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/887#discussion_r39290870
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java
---
    @@ -800,7 +809,11 @@ private boolean attemptType(String key, CatalogItemType candidateCiType)
{
                         // (when we're not given a key, the previous block should apply)
                         errors.add(e);
                     } else {
    -                    // all other cases, the error is probably due to us not getting the
type right, ignore it
    +                    // all other cases, the error is probably due to us not getting the
type right, probably ignore it
    +                    // but cache it if we've checked entity, we'll use that as fallback
errors
    --- End diff --
    
    Not sure I follow - why would we get the type wrong for non-entities? Have we guessed
that it was an entity, without being able to tell from the context if its instead a policy/enricher/etc?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message