brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix for BROOKLYN-169 - CreateUser...
Date Wed, 09 Sep 2015 10:01:05 GMT
Github user aledsage commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/877#issuecomment-138861495
  
    Thank @ygy 
    
    * I agree with Alex: the `BYON_USER_RESET_PASSWORD` config key should be on the policy
rather than on `SshMachineLocation`. I don't understand your comment "I've moved it to `SshMachineLocation`
so it is backward compatible as much as it can. It guarantees that customers will make no
changes at their end." This is a new config key. Also, see below about the default being `false`.
    * `BYON_USER_RESET_PASSWORD` should default to `false`. We only got away with it with
VMs provisioned with jclouds because the `user` was using an ssh-key rather than a password.
We should not touch the existing user's configuration at all.
    * The name `byonResetLogin` feels wrong. This happens for byon, but it would also happen
for non-byon locations. I'd change it to `RESET_LOGIN_USER` for the constant, and `createuser.vm.user.resetLoginUser`
for the string name, with a `@SetFromFlag("resetLoginUser")`.
    
    @ahgittin it's in location-jclouds because it uses the jclouds `AdminAccess.builder` to
build the command to be executed. However, it then executes it directly using the `SshMachineLocation`
so works against BYON as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message