Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7057017774 for ; Mon, 31 Aug 2015 08:29:29 +0000 (UTC) Received: (qmail 30670 invoked by uid 500); 31 Aug 2015 08:29:29 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 30628 invoked by uid 500); 31 Aug 2015 08:29:29 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 30615 invoked by uid 99); 31 Aug 2015 08:29:29 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Aug 2015 08:29:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 95E2118282A for ; Mon, 31 Aug 2015 08:29:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.975 X-Spam-Level: X-Spam-Status: No, score=0.975 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id bgOiU74qXO2c for ; Mon, 31 Aug 2015 08:29:21 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with SMTP id C4BCA42B2E for ; Mon, 31 Aug 2015 08:29:20 +0000 (UTC) Received: (qmail 30595 invoked by uid 99); 31 Aug 2015 08:29:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Aug 2015 08:29:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 0ED2DDFCE0; Mon, 31 Aug 2015 08:29:20 +0000 (UTC) From: alasdairhodge To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: Don't treat *all* config as a "re... Content-Type: text/plain Message-Id: <20150831082920.0ED2DDFCE0@git1-us-west.apache.org> Date: Mon, 31 Aug 2015 08:29:20 +0000 (UTC) Github user alasdairhodge commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/870#issuecomment-136299460 Context: a relatively recent change meant that *all* config keys were searched for any type that can be coerced to a `PortRange`, which was then added to the set of "required open ports" by `SoftwareProcessImpl`. However, since type coercions are defined from integer/long/string, this resulted in spurious port values being added, and in at least one customer scenario, a runtime exception when a value >16 bits was incorrectly subsumed into the port set. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---