Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: aledsage <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-866-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-866-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Winrm commands stdin,
 stdout, std...
Content-Type: text/plain
Message-Id: <20150826101833.6DAD8DFE80@git1-us-west.apache.org>
Date: Wed, 26 Aug 2015 10:18:33 +0000 (UTC)

Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/866#discussion_r37966477
  
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java ---
    @@ -18,12 +18,17 @@
      */
     package org.apache.brooklyn.entity.software.base;
     
    +import io.cloudsoft.winrm4j.winrm.WinRmToolResponse;
     import org.apache.brooklyn.api.entity.EntityLocal;
     import org.apache.brooklyn.core.entity.Attributes;
     import org.apache.brooklyn.location.winrm.WinRmMachineLocation;
     import org.apache.brooklyn.util.net.UserAndHostAndPort;
    +import org.apache.brooklyn.util.text.Strings;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
     
     public class VanillaWindowsProcessWinRmDriver extends AbstractSoftwareProcessWinRmDriver implements VanillaWindowsProcessDriver {
    +    Logger LOG = LoggerFactory.getLogger(VanillaWindowsProcessWinRmDriver.class);
    --- End diff --
    
    Always declare these `private static final Logger LOG =`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---