Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 724DC174BB for ; Wed, 26 Aug 2015 07:40:44 +0000 (UTC) Received: (qmail 85791 invoked by uid 500); 26 Aug 2015 07:40:44 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 85756 invoked by uid 500); 26 Aug 2015 07:40:44 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 85745 invoked by uid 99); 26 Aug 2015 07:40:44 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2015 07:40:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AC056181BC3 for ; Wed, 26 Aug 2015 07:40:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.975 X-Spam-Level: X-Spam-Status: No, score=0.975 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.006, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id pTnffbp70iYl for ; Wed, 26 Aug 2015 07:40:35 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 494DB34A1A for ; Wed, 26 Aug 2015 07:40:34 +0000 (UTC) Received: (qmail 85425 invoked by uid 99); 26 Aug 2015 07:40:33 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2015 07:40:32 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DCC7EDFC78; Wed, 26 Aug 2015 07:40:32 +0000 (UTC) From: tbouron To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: [BROOKLYN-166] add codemirror, ya... Content-Type: text/plain Message-Id: <20150826074032.DCC7EDFC78@git1-us-west.apache.org> Date: Wed, 26 Aug 2015 07:40:32 +0000 (UTC) Github user tbouron commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/865#issuecomment-134880370 Tested, it works great. There are indeed two scroll but that should be easily fixable with a bit of CSS. Also, the editor is only one line height, could we extend to the height of the pop-up by default? Regarding the autocompletion, my view on that is first to pull out the catalogue entities when we are to a `type:` line. We can even imagine to have specific hints based on where we are, like having all the provisioning properties after a `provisioning.properties:` and so on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---