Return-Path: X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 91DA21856D for ; Tue, 11 Aug 2015 20:56:50 +0000 (UTC) Received: (qmail 82751 invoked by uid 500); 11 Aug 2015 20:56:37 -0000 Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org Received: (qmail 82716 invoked by uid 500); 11 Aug 2015 20:56:37 -0000 Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@brooklyn.incubator.apache.org Delivered-To: mailing list dev@brooklyn.incubator.apache.org Received: (qmail 82699 invoked by uid 99); 11 Aug 2015 20:56:37 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2015 20:56:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 39326DC531 for ; Tue, 11 Aug 2015 20:56:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.759 X-Spam-Level: X-Spam-Status: No, score=0.759 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.222, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 3pRNSsGEEb2A for ; Tue, 11 Aug 2015 20:56:29 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with SMTP id 6D7B624B33 for ; Tue, 11 Aug 2015 20:56:28 +0000 (UTC) Received: (qmail 82419 invoked by uid 99); 11 Aug 2015 20:56:21 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Aug 2015 20:56:21 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 39639E0941; Tue, 11 Aug 2015 20:56:21 +0000 (UTC) From: aledsage To: dev@brooklyn.incubator.apache.org Reply-To: dev@brooklyn.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-brooklyn pull request: Core test bundles Content-Type: text/plain Message-Id: <20150811205621.39639E0941@git1-us-west.apache.org> Date: Tue, 11 Aug 2015 20:56:21 +0000 (UTC) Github user aledsage commented on the pull request: https://github.com/apache/incubator-brooklyn/pull/810#issuecomment-130070640 @hzbarcea can you say more about why you deleted the test jars here, and disabled the tests? These jars make writing OSGi tests much simpler (because the build doesn't need to generate these artifacts from other modules first, and we don't need to worry as much about the classes accidentally being on the classpath). We never liked having the tests jars checked in, but it was worth it to get the test coverage. Why disable the OSGi tests before the Karaf work starts? @ahgittin any comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---