brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-162) Update package names to org.apache.brooklyn.*
Date Thu, 20 Aug 2015 11:00:48 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704682#comment-14704682
] 

ASF GitHub Bot commented on BROOKLYN-162:
-----------------------------------------

GitHub user aledsage opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/856

    [BROOKLYN-162] move packages

    As discussed in https://github.com/apache/incubator-brooklyn/pull/854
    
    See individual commits descriptions for details of changes. Copy-pasted below for your
convenience.
    
        commit e7420b1e4194cbe597a9d467bddc1a197804af50
        Author: Aled Sage <aled.sage@gmail.com>
        Date:   Thu Aug 20 11:32:42 2015 +0100
    
        move WindowsPerformanceCounterSensors to o.a.b.core.sensor.windows
        
        - Was previously in software-base, in o.a.b.sensor.winrm.
        - Renamed to .windows to be consistent with .feed.windows
        - Moved to core to be consistent with .sensor.ssh and .sensor.http
    
        commit 1dde632fe624e1efec91573715c9470e12fd18e9
        Author: Aled Sage <aled.sage@gmail.com>
        Date:   Thu Aug 20 11:27:20 2015 +0100
    
        Move HttpRequestSensor to o.a.b.core.sensor.http
    
        commit 080d2de0806f5524886b4d6d8bfea7c71a45dbc7
        Author: Aled Sage <aled.sage@gmail.com>
        Date:   Thu Aug 20 11:24:20 2015 +0100
    
        Move o.a.b.sensor.ssh contents to core
        
        - Moved SshCommandEffector (which strangely was in .sensor.ssh) to
          o.a.b.core.effector.ssh
        - Moved SshCommandSensor (which strangely was in .sensor.ssh) to
          o.a.b.core.sensor.ssh
        - Changed these classes to reference config in BrooklynConfigKeys,
          rather than in SoftwareProcess.*
        - Added BrooklynConfigKeys.SHELL_ENVIRONMENT, which SoftwareProcess
          now uses.
        - Made SshCommandSensor.makeCommandExecutingInDirectory public and
          marked as @Beta (was previously static package-private, for use
          by SshCommandEffector as well).
        - Split SshCommandIntegrationTest into two:
          - SshCommandEffectorIntegrationTest (and removed unnecessary tempFile
            creation)
          - SshCommandSensorIntegrationTest (and moved tempFile creation/deletion
            into setUp/tearDown)
    
        commit 8e439bdb398e12d12c4c7d5aeff31497207be742
        Author: Aled Sage <aled.sage@gmail.com>
        Date:   Thu Aug 20 10:47:38 2015 +0100
    
        Move HasBrooklynManagementContext to o.a.b.core.mgmt
        
        - Was previously in o.a.b.camp.brooklyn.api, in the core module

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/incubator-brooklyn refactor/move-packages-20150820

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/856.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #856
    
----
commit 8e439bdb398e12d12c4c7d5aeff31497207be742
Author: Aled Sage <aled.sage@gmail.com>
Date:   2015-08-20T09:47:38Z

    Move HasBrooklynManagementContext to o.a.b.core.mgmt
    
    - Was previously in o.a.b.camp.brooklyn.api, in the core module

commit 080d2de0806f5524886b4d6d8bfea7c71a45dbc7
Author: Aled Sage <aled.sage@gmail.com>
Date:   2015-08-20T10:24:20Z

    Move o.a.b.sensor.ssh contents to core
    
    - Moved SshCommandEffector (which strangely was in .sensor.ssh) to 
      o.a.b.core.effector.ssh
    - Moved SshCommandSensor (which strangely was in .sensor.ssh) to 
      o.a.b.core.sensor.ssh
    - Changed these classes to reference config in BrooklynConfigKeys, 
      rather than in SoftwareProcess.*
    - Added BrooklynConfigKeys.SHELL_ENVIRONMENT, which SoftwareProcess
      now uses.
    - Made SshCommandSensor.makeCommandExecutingInDirectory public and
      marked as @Beta (was previously static package-private, for use
      by SshCommandEffector as well).
    - Split SshCommandIntegrationTest into two:
      - SshCommandEffectorIntegrationTest (and removed unnecessary tempFile
        creation)
      - SshCommandSensorIntegrationTest (and moved tempFile creation/deletion
        into setUp/tearDown)

commit 1dde632fe624e1efec91573715c9470e12fd18e9
Author: Aled Sage <aled.sage@gmail.com>
Date:   2015-08-20T10:27:20Z

    Move HttpRequestSensor to o.a.b.core.sensor.http

commit e7420b1e4194cbe597a9d467bddc1a197804af50
Author: Aled Sage <aled.sage@gmail.com>
Date:   2015-08-20T10:32:42Z

    move WindowsPerformanceCounterSensors to o.a.b.core.sensor.windows
    
    - Was previously in software-base, in o.a.b.sensor.winrm.
    - Renamed to .windows to be consistent with .feed.windows
    - Moved to core to be consistent with .sensor.ssh and .sensor.http

----


> Update package names to org.apache.brooklyn.*
> ---------------------------------------------
>
>                 Key: BROOKLYN-162
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-162
>             Project: Brooklyn
>          Issue Type: Task
>    Affects Versions: 0.7.0
>            Reporter: Hadrian Zbarcea
>             Fix For: 0.8.0
>
>
> As discussed on the list we should update the package names sooner rather than later.
This issue is meant to track the progress of that task.
> To see what packages need conversion, use:
> {noformat}find . -name brooklyn | grep -v target | grep -v org/apache/brooklyn | grep
-v com/acme/sample{noformat}
> To look for stale items in a project once you think you've updated, the following can
be useful (it's imperfect, but handy):
> {noformat}grep -r "[^e].brooklyn[^\w]" . | grep -v import | grep -v artifactId{noformat}
> In some cases, split packages are being addressed by this refactoring. ([~hzbarcea@gmail.com]
is there a separate issue for that?)
> To minimize interference I added the list of subprojects. Please add your name to the
module you want to take care of so others would know you are taking care of it. I'd suggest
adding a check mark to what's already done and committed (v) and a (userid) for wip.  Note
however that things may not have been updated, so also use the command above.
> {noformat}
> (v) ./api/
>  ./camp/camp-base/
>  ./camp/camp-server/
> (v) ./camp/
> (hadrian) ./core/
> (v) ./core/src/test/dependencies/osgi/entities/
> (v) ./core/src/test/dependencies/osgi/more-entities-v1/
> (v) ./core/src/test/dependencies/osgi/more-entities-v2-evil-twin/
> (v) ./core/src/test/dependencies/osgi/more-entities-v2/
>  ./examples/global-web-fabric/
> (v)  ./examples/
> (v)  ./examples/simple-messaging-pubsub/
> (v)  ./examples/simple-nosql-cluster/
> (v)  ./examples/simple-web-cluster/
> (v)  ./examples/webapps/hello-world-sql/
> (v)  ./examples/webapps/hello-world-webapp/
> (v)  ./examples/webapps/
>  ./locations/jclouds/
> (v) ./parent/
>  ./policy/
>  ./
> (v)  ./sandbox/cassandra-multicloud-snitch/
> (v)  ./sandbox/database/
> (v)  ./sandbox/extra/
> (v)  ./sandbox/mobile-app/
> (v)  ./sandbox/monitoring/
> (v)  ./sandbox/nosql/
>  ./software/base/
>  ./software/database/
>  ./software/messaging/
>  ./software/monitoring/
>  ./software/network/
>  ./software/nosql/
>  ./software/osgi/
>  ./software/webapp/
>  ./storage/hazelcast/
>  ./usage/all/
>  ./usage/archetypes/quickstart/
>  ./usage/archetypes/quickstart/src/brooklyn-sample/
>  ./usage/archetypes/quickstart/src/main/resources/archetype-resources/
> ./usage/archetypes/quickstart/src/test/resources/projects/integration-test-1/reference/
>  ./usage/archetypes/quickstart/target/classes/archetype-resources/
>  ./usage/archetypes/quickstart/target/test-classes/projects/integration-test-1/project/brooklyn-sample/
>  ./usage/archetypes/quickstart/target/test-classes/projects/integration-test-1/reference/
> (v) ./usage/camp/
> (v) ./usage/cli/
> (v) ./usage/dist/
>  ./usage/downstream-parent/
>  ./usage/jsgui/
>  ./usage/launcher/
>  ./usage/logback-includes/
>  ./usage/logback-xml/
> (v) ./usage/qa/
> (v) ./usage/rest-api/
>  ./usage/rest-client/
> (v) ./usage/rest-server/
> (v) ./usage/test-support/
>  ./utils/common/
>  ./utils/groovy/
>  ./utils/jmx/jmxmp-ssl-agent/
>  ./utils/jmx/jmxrmi-agent/
> (v) ./utils/rest-swagger/
>  ./utils/test-support/
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message