brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Svetoslav Neykov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-161) Use generated test bundles
Date Wed, 05 Aug 2015 10:28:04 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14655145#comment-14655145
] 

Svetoslav Neykov commented on BROOKLYN-161:
-------------------------------------------

Sources for all of the osgi bundles live in https://github.com/apache/incubator-brooklyn/tree/master/core/src/test/dependencies/osgi.
They are built manually if changed.
1. A bunch of core unit tests depend on the bundles which again depend on core, so there's
not straightforward way to build them as part of the normal workflow
2. Building them along the other projects will waste time as they are seldomly changed - would
be nice to cache builds somehow if we get to include them in the build.

Would be nice to improve on this, so any ideas are welcome. Also the files are not part of
the source release and each binary file has a corresponding .txt file with an explanation.

> Use generated test bundles
> --------------------------
>
>                 Key: BROOKLYN-161
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-161
>             Project: Brooklyn
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 0.8.0
>
>
> While renaming packages I stumbled across the following error:
> {noformat}
> Failed tests: 
>   CatalogOsgiVersionMoreEntityTest.testAutoscanWithClasspathCanCreateSpecs:235->AbstractYamlTest.addCatalogItems:156
» CompoundRuntime
>   CatalogOsgiVersionMoreEntityTest.testMoreEntityV2AutoscanWithClasspath:177->AbstractYamlTest.addCatalogItems:156
» CompoundRuntime
>   CatalogOsgiVersionMoreEntityTest.testMorePolicyV2AutoscanWithClasspath:204->AbstractYamlTest.addCatalogItems:156
» CompoundRuntime
> {noformat}
> For now I opted to ignore the tests, but right after finishing the rename I need to come
back and address this. Part of the problem is related to the way the bundles in ./core/src/test/resources/brooklyn/osgi/
are built, but more importantly I don't think we should have bundles in the repository, we
should instead generate them from sources. I couldn't find the sources in the repo though,
they seem to be generated from some external project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message