brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadrian Zbarcea (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-161) Use generated test bundles
Date Mon, 10 Aug 2015 01:51:45 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679467#comment-14679467
] 

Hadrian Zbarcea commented on BROOKLYN-161:
------------------------------------------

I started working on this one as it seems to be a bit of a blocker for the package rename
in ./api.

I moved the code from ./core/src/test/dependencies/osgi somewhere in ./utils/test-bundles
(name can be changed), but now I have a circular(-ish) dependency between the core and the
test-bundles. The goal is to get core to depend <scope>test</scope> on the test
bundles and remove the jars from core/src/test/resources/brooklyn/osgi.

> Use generated test bundles
> --------------------------
>
>                 Key: BROOKLYN-161
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-161
>             Project: Brooklyn
>          Issue Type: Improvement
>    Affects Versions: 0.7.0
>            Reporter: Hadrian Zbarcea
>            Priority: Critical
>             Fix For: 0.8.0
>
>
> While renaming packages I stumbled across the following error:
> {noformat}
> Failed tests: 
>   CatalogOsgiVersionMoreEntityTest.testAutoscanWithClasspathCanCreateSpecs:235->AbstractYamlTest.addCatalogItems:156
» CompoundRuntime
>   CatalogOsgiVersionMoreEntityTest.testMoreEntityV2AutoscanWithClasspath:177->AbstractYamlTest.addCatalogItems:156
» CompoundRuntime
>   CatalogOsgiVersionMoreEntityTest.testMorePolicyV2AutoscanWithClasspath:204->AbstractYamlTest.addCatalogItems:156
» CompoundRuntime
> {noformat}
> For now I opted to ignore the tests, but right after finishing the rename I need to come
back and address this. Part of the problem is related to the way the bundles in ./core/src/test/resources/brooklyn/osgi/
are built, but more importantly I don't think we should have bundles in the repository, we
should instead generate them from sources. I couldn't find the sources in the repo though,
they seem to be generated from some external project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message