brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Winrm commands stdin, stdout, std...
Date Wed, 26 Aug 2015 10:18:33 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: software/base/src/main/java/org/apache/brooklyn/entity/software/base/
    @@ -18,12 +18,17 @@
    +import io.cloudsoft.winrm4j.winrm.WinRmToolResponse;
     import org.apache.brooklyn.api.entity.EntityLocal;
     import org.apache.brooklyn.core.entity.Attributes;
     import org.apache.brooklyn.location.winrm.WinRmMachineLocation;
    +import org.apache.brooklyn.util.text.Strings;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
     public class VanillaWindowsProcessWinRmDriver extends AbstractSoftwareProcessWinRmDriver
implements VanillaWindowsProcessDriver {
    +    Logger LOG = LoggerFactory.getLogger(VanillaWindowsProcessWinRmDriver.class);
    --- End diff --
    Always declare these `private static final Logger LOG =`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message