brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Feature: catalog item disabled
Date Thu, 20 Aug 2015 20:42:29 GMT
Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/850#discussion_r37578668
  
    --- Diff: usage/rest-api/src/main/java/org/apache/brooklyn/rest/api/CatalogApi.java ---
    @@ -314,12 +314,39 @@ public Response getIcon(
             @ApiParam(name = "version", value = "version identifier of catalog item (application,
entity, policy, location)", required=true)
             @PathParam("version") String version);
     
    +    /**
    +     * @deprecated since 0.8.0; use "/entities/{itemId}/deprecated" with payload of true/false
    +     */
    +    @Deprecated
         @POST
         @Path("/entities/{itemId}/deprecated/{deprecated}")
    -    public void setDeprecated(
    +    public void setDeprecatedLegacy(
             @ApiParam(name = "itemId", value = "The ID of the catalog item to be deprecated",
required = true)
             @PathParam("itemId") String itemId,
             @ApiParam(name = "deprecated", value = "Whether or not the catalog item is deprecated",
required = true)
             @PathParam("deprecated") boolean deprecated);
    +    
    +    @POST
    +    @Consumes({MediaType.APPLICATION_JSON, MediaType.APPLICATION_OCTET_STREAM, MediaType.TEXT_PLAIN})
    +    @ApiErrors(value = {
    +            @ApiError(code = 404, reason = "Undefined catalog item"),
    +    })
    +    @Path("/entities/{itemId}/disabled")
    +    public void setDisabled(
    +        @ApiParam(name = "itemId", value = "The ID of the catalog item to be disabled",
required = true)
    +        @PathParam("itemId") String itemId,
    +        @ApiParam(name = "deprecated", value = "Whether or not the catalog item is disabled",
required = true)
    --- End diff --
    
    `name=disabled`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message