brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hzbarcea <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: completes the org.apache-fication
Date Wed, 19 Aug 2015 04:50:05 GMT
Github user hzbarcea commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/844#issuecomment-132444589
  
    @aledsage excellent summary not much to add.
    
    * +1 on the proposal to keep the OSGi semantics of 'internal'
    * once this is done, there is a bit of change needed for the felix bundle plugin to properly
add Import- and Export-Package with proper version ranges in the manifest. I can take care
of that.
    * on the OSGi test artifacts I am not sure it's a good idea to move them back to core/src/test/dependencies,
and not a good idea to keep them as binaries. I am -1 on that for now. With the karaf infrastructure
will come a paxexam based itest environment where they may prove useful. I would suggest we
make a decision once that is in place (should be days after the refactoring). There are other
solutions, btw, such as a separate git repo for 'test' or 'sample' bundles.
    * the docs will require a full review indeed, I am planning on going very carefully through
them once this is done.
    
    I tested #844 locally and there are test failure. Based on the work done, I also closed
#841 per @ahgittin recommendation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message