brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: completes the org.apache-fication...
Date Wed, 19 Aug 2015 01:20:36 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/844#issuecomment-132409570
  
    Great stuff @aledsage .  I've added comments in the google doc.  This builds nicely so
good to merge in my view (would like one sanity check review).
    
    Then we should:
    * let you go through any further restructure ASAP (based on doc)
    * restore the OSGi items (putting back into `core/src/test/dependencies` and checking
in binaries gets my vote, as they hardly ever change and are just noise to build, just like
the WAR files)
    * do an `egrep -r '[^e].brooklyn\.([a-z]+\.)*[A-Z]'` on src folders and docs to fix class
names from text which weren't picked up
    * apply XSLT transformers to fix classes in persistence (and test with nested refs)
    * also apply the class-rename strategy to the java lookup, with warning, so old blueprints
work
    
    Anything else?
    
    But fortunately once we've done the first one above, I think we can let people know snapshot
is stable again!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message