brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Core test bundles
Date Tue, 18 Aug 2015 13:04:03 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/810#issuecomment-132199426
  
    yes, the circular dep is irritating.  we want core to be able to test osgi bundles which
in turn use core.  i think options are:
    
    * refactor the osgi loading support so it isn't in core (a bit bad?)
    * hack maven into building these deps in a phase between src and test (hard i think?)
    * build these manually, after a core `-DskipTests` build and before the build which runs
test
    
    they change so infrequently and they are noise for most people so i think the last one
is the best, even if it means having binaries checked in as test resources. however while
refactoring is going on this will be a problem, so i suggest we wait for refactoring to stabilise
then revert this, moving them back to `core/../dependencies`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message