brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Performance improvements and othe...
Date Tue, 11 Aug 2015 16:35:20 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/790#discussion_r36766616
  
    --- Diff: software/webapp/src/test/java/brooklyn/test/entity/TestJavaWebAppEntity.java
---
    @@ -38,7 +39,7 @@
      * Mock web application server entity for testing.
      */
     @ImplementedBy(TestJavaWebAppEntityImpl.class)
    -public interface TestJavaWebAppEntity extends VanillaJavaApp, WebAppService {
    +public interface TestJavaWebAppEntity extends VanillaJavaApp, WebAppService, EntityLocal
{
    --- End diff --
    
    Makes tests a little simpler, because don't need to cast to `EntityLocal` for methods
like `setAttribute(...)`. It would be nice to get rid of `EntityLocal` entirely!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message