brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: [BROOKLYN-162] Renaming of the No...
Date Thu, 06 Aug 2015 16:31:05 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/800#discussion_r36435392
  
    --- Diff: examples/simple-nosql-cluster/src/main/java/org/apache/brooklyn/demo/CumulusRDFApplication.java
---
    @@ -138,8 +139,8 @@ public void initApp() {
                 cassandra = addChild(EntitySpec.create(CassandraFabric.class)
                         .configure(CassandraDatacenter.CLUSTER_NAME, "Brooklyn")
                         .configure(CassandraDatacenter.INITIAL_SIZE, getConfig(CASSANDRA_CLUSTER_SIZE))
// per location
    -                    .configure(CassandraDatacenter.ENDPOINT_SNITCH_NAME, "brooklyn.entity.nosql.cassandra.customsnitch.MultiCloudSnitch")
    -                    .configure(CassandraNode.CUSTOM_SNITCH_JAR_URL, "classpath://brooklyn/entity/nosql/cassandra/cassandra-multicloud-snitch.jar")
    +                    .configure(CassandraDatacenter.ENDPOINT_SNITCH_NAME, "org.apache.brooklyn.entity.nosql.cassandra.customsnitch.MultiCloudSnitch")
    --- End diff --
    
    Note that this will require us re-building the jar for MultiCloudSnitch (which shouldn't
even be in brooklyn!).
    
    See the comment at https://github.com/apache/incubator-brooklyn/pull/802#issuecomment-128424637
    
    Also see docs/_extra/big_examples/nosql-cassandra/cassandra.include.md lines 191 and 205,
where the `MultiCloudSnitch` is mentioned. We should do a global search for "MultiCloudSnitch".
    
    Don't worry about it here. Let's fix it by moving MultiCloudSnitch somewhere more sensible
in a completely different PR!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message