brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikezaccardo <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Add basic sensors to RedisCluster
Date Mon, 03 Aug 2015 17:03:57 GMT
Github user mikezaccardo commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/782#discussion_r36106153
  
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/redis/RedisClusterImpl.java
---
    @@ -20,49 +20,73 @@
     
     import java.util.Collection;
     
    +import brooklyn.enricher.Enrichers;
     import brooklyn.entity.Entity;
     import brooklyn.entity.basic.AbstractEntity;
     import brooklyn.entity.basic.Entities;
     import brooklyn.entity.group.DynamicCluster;
     import brooklyn.entity.proxying.EntitySpec;
     import brooklyn.entity.trait.Startable;
    +import brooklyn.event.AttributeSensor;
    +import brooklyn.event.basic.Sensors;
     import brooklyn.location.Location;
     
    +import com.google.common.collect.ImmutableList;
    +import com.google.common.collect.ImmutableMap;
    +
     public class RedisClusterImpl extends AbstractEntity implements RedisCluster {
     
    -    protected RedisStore master;
    -    protected DynamicCluster slaves;
    +    private AttributeSensor<RedisStore> MASTER = Sensors.newSensor(RedisStore.class,
"redis.master");
    --- End diff --
    
    In this case the attributes are used exclusively internally in lieu of storing master
and slaves as non-persistent member variables, so I have left them as `private static`.  However,
if you feel that they should be `public` anyway, I will make that change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message