Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@brooklyn.incubator.apache.org
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-771-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-771-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Don't leak machines on
 shutdown
Content-Type: text/plain
Message-Id: <20150729135311.F1B16DFA0A@git1-us-west.apache.org>
Date: Wed, 29 Jul 2015 13:53:11 +0000 (UTC)

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/771#discussion_r35760476
  
    --- Diff: usage/rest-server/src/test/java/brooklyn/rest/BrooklynRestApiLauncher.java ---
    @@ -235,6 +238,7 @@ private ContextHandler servletContextHandler(ManagementContext managementContext
             ResourceConfig config = new DefaultResourceConfig();
             for (Object r: BrooklynRestApi.getAllResources())
                 config.getSingletons().add(r);
    +        config.getSingletons().add(new ShutdownRequestListenerProvider(new TestShutdownRequestListener()));
    --- End diff --
    
    Update code to use the field. The field itself is not used elsewhere, but added it anyway for consistency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---