brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Don't use hostname when obtaining...
Date Wed, 15 Jul 2015 14:23:06 GMT
GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/747

    Don't use hostname when obtaining machines

    By default Softlayer machines will have a hostname of the form `xxxx.local.brooklyncentral.com`
which resolves to a parked domain, not the public IP of the machine. When the machine has
privte IP only the hostname was used instead of the private IP which caused a failure. This
commit removes the hostname fallback - I don't see a valid reason why it should be included.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn fix/ip-only-obtain

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/747.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #747
    
----
commit b2ec359cf1e959d5831237ae59c88a7175c99d98
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2015-07-15T14:22:04Z

    Don't use hostname when obtaining machines
    
    By default Softlayer machines will have a hostname of the form xxxx.local.brooklyncentral.com
which resolves to a parked domain, not the public IP of the machine. When the machine has
privte IP only the hostname was used instead of the private IP which caused a failure. This
commit removes the hostname fallback - I don't see a valid reason why it should be included.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message