brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <>
Subject [GitHub] incubator-brooklyn pull request: Add basic sensors to RedisCluster
Date Fri, 31 Jul 2015 23:47:51 GMT
Github user aledsage commented on a diff in the pull request:
    --- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/redis/
    @@ -20,49 +20,73 @@
     import java.util.Collection;
    +import brooklyn.enricher.Enrichers;
     import brooklyn.entity.Entity;
     import brooklyn.entity.basic.AbstractEntity;
     import brooklyn.entity.basic.Entities;
     import brooklyn.entity.proxying.EntitySpec;
     import brooklyn.entity.trait.Startable;
    +import brooklyn.event.AttributeSensor;
    +import brooklyn.event.basic.Sensors;
     import brooklyn.location.Location;
     public class RedisClusterImpl extends AbstractEntity implements RedisCluster {
    -    protected RedisStore master;
    -    protected DynamicCluster slaves;
    +    private AttributeSensor<RedisStore> MASTER = Sensors.newSensor(RedisStore.class,
    +    private AttributeSensor<DynamicCluster> SLAVES = Sensors.newSensor(DynamicCluster.class,
         public RedisClusterImpl() {
         public RedisStore getMaster() {
    -        return master;
    +        return getAttribute(MASTER);
         public DynamicCluster getSlaves() {
    -        return slaves;
    +        return getAttribute(SLAVES);
         public void start(Collection<? extends Location> locations) {
    --- End diff --
    Also see the code in things like `DynamicCluster.start(locations)`, which does things
like `ServiceStateLogic.setExpectedState(this, Lifecycle.STARTING);`. That gives more visibility
of what the entity is doing and better error reporting. The finally block also ensures that
we'll correctly report failures, and will stop the green-spinning in the web-console that
was shown while starting.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message