brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Reduces excessively chatty loggin...
Date Thu, 30 Jul 2015 20:20:29 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/686#discussion_r35915683
  
    --- Diff: core/src/main/java/brooklyn/entity/rebind/PeriodicDeltaChangeListener.java ---
    @@ -494,5 +496,8 @@ public synchronized void onChanged(BrooklynObject instance) {
         public PersistenceExceptionHandler getExceptionHandler() {
             return exceptionHandler;
         }
    -    
    +
    +    protected boolean shouldLogCheckpoint() {
    +        return (checkpointLogCount.get() < 5) || (checkpointLogCount.get() % 1000
== 0);
    --- End diff --
    
    Why the magic number 5?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message