brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sjcorbett <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Support suspending machines
Date Tue, 28 Jul 2015 13:34:12 GMT
Github user sjcorbett commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/763#discussion_r35646804
  
    --- Diff: software/base/src/main/java/brooklyn/entity/software/MachineLifecycleEffectorTasks.java
---
    @@ -151,8 +151,18 @@ public void attachLifecycleEffectors(Entity entity) {
                     .build();
         }
     
    +    /** @see {@link #newStartEffector()} */
    +    public Effector<Void> newSuspendEffector() {
    +        return Effectors.effector(Void.class, "suspend")
    +                .description("Suspend the process/service represented by an entity")
    +                .parameter(StopSoftwareParameters.STOP_PROCESS_MODE)
    +                .parameter(StopSoftwareParameters.STOP_MACHINE_MODE)
    +                .impl(newSuspendEffectorTask())
    +                .build();
    +    }
    --- End diff --
    
    .. except of course that when suspending a machine `JcloudsLocation` does not call the
pre- and post-release methods on any `JcloudsLocationCustomizers` attached to the location.
I think this is fair given that the machine may be resumed. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message