brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aledsage <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Don't leak machines on shutdown
Date Tue, 28 Jul 2015 10:08:02 GMT
Github user aledsage commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/771#discussion_r35632364
  
    --- Diff: usage/launcher/src/main/java/brooklyn/launcher/BrooklynLauncher.java ---
    @@ -772,6 +782,7 @@ protected void startWebApps() {
                 webServer.setPublicAddress(publicAddress);
                 if (port!=null) webServer.setPort(port);
                 if (useHttps!=null) webServer.setHttpsEnabled(useHttps);
    +            webServer.setShutdownRequestListener(shutdownRequestListener);
    --- End diff --
    
    I was initilly a little worried about nulls being passed through here (but looks like
it's ok at the end, where it's finally used).
    
    If nulls are allowed, then worth including `@Nullable` on the parameter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message