brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Update BrooklynNode default expan...
Date Fri, 24 Jul 2015 11:15:12 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/745#discussion_r35413929
  
    --- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeSshDriver.java
---
    @@ -127,8 +127,8 @@ public void install() {
             String uploadUrl = entity.getConfig(BrooklynNode.DISTRO_UPLOAD_URL);
             
             // Need to explicitly give file, because for snapshot URLs you don't get a clean
filename from the URL.
    -        // This filename is used to generate the first URL to try: 
    -        // file://$HOME/.brooklyn/repository/BrooklynNode/0.6.0-SNAPSHOT/brooklyn-0.6.0-SNAPSHOT-dist.tar.gz
    +        // This filename is used to generate the first URL to try: [BROOKLYN_VERSION_BELOW]
    +        // file://$HOME/.brooklyn/repository/BrooklynNode/0.8.0-SNAPSHOT/brooklynnode-0.8.0-snapshot.tar.gz
    --- End diff --
    
    Yes, the filename is lowercase (I copied the URL from stdin). See https://github.com/apache/incubator-brooklyn/blob/master/core/src/main/java/brooklyn/entity/drivers/downloads/DownloadProducerFromLocalRepo.java#L51.
    
    Good point about `BROOKLYN_VERSION_BELOW`, the lower case part won't get replaced, so
I think best is to just remove the marker and leave the version as is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message