brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix SshMachineLocation unable to ...
Date Thu, 23 Jul 2015 12:49:32 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/757#discussion_r35317252
  
    --- Diff: core/src/main/java/brooklyn/location/basic/ByonLocationResolver.java ---
    @@ -96,7 +96,11 @@ protected ConfigBag extractConfig(Map<?,?> locationFlags, String
spec, brooklyn.
             String user = (String) config.getStringKey("user");
             Integer port = (Integer) TypeCoercions.coerce(config.getStringKey("port"), Integer.class);
             Class<? extends MachineLocation> locationClass = OS_TO_MACHINE_LOCATION_TYPE.get(config.get(OS_FAMILY));
    -        
    +
    +        MutableMap<String, Object> defaultProps = MutableMap.of();
    +        if (user != null) defaultProps.add("user", user);
    --- End diff --
    
    `MutableMap` supports `addIfNotNull` to avoid the check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message