brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fix SshMachineLocation unable to ...
Date Thu, 23 Jul 2015 09:27:28 GMT
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/757#issuecomment-124032299
  
    The changes leading to this were merged recently - https://github.com/apache/incubator-brooklyn/pull/721.
It's surprising to have null values in the map, so might be worth fixing the new code as well.
Regardless your change is valid and agree that null values should cause the default being
used. What I'd like to see is the same guards to the other `getOptionalVal` overloading implementation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message