brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hzbarcea <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Release 08
Date Tue, 14 Jul 2015 14:51:41 GMT
Github user hzbarcea commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/737#discussion_r34576325
  
    --- Diff: software/nosql/pom.xml ---
    @@ -295,4 +295,26 @@
             </plugins>
           </pluginManagement>
         </build>
    +
    +  <profiles>
    +    <profile>
    +      <id>defaultProfile</id>
    +      <activation>
    +	<property><name>!brooklyn.cloudtest</name></property>
    +      </activation>
    +      <build>
    +        <plugins>
    +          <plugin>
    +            <groupId>org.apache.maven.plugins</groupId>
    +            <artifactId>maven-surefire-plugin</artifactId>
    +            <configuration>
    +              <excludes>
    +                <exclude>**/CassandraFabricTest.java</exclude>
    --- End diff --
    
    Fair enough. I assume however this is not a blocker for merging the PR, right? We can
take a look later (me or somebody more experienced in that particular area).
    
    From what I recall the issue was related to host seeds for the cassandra cluster when
running on just localhost. After all the refactoring it looks like that hack is no longer
necessary. Will add a commit shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message