Return-Path: 
 <dev-return-8300-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 031CD18928
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Mon, 29 Jun 2015 10:09:11 +0000 (UTC)
Received: (qmail 13659 invoked by uid 500); 29 Jun 2015 10:09:10 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 13627 invoked by uid 500); 29 Jun 2015 10:09:10 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 13616 invoked by uid 99); 29 Jun 2015 10:09:10 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jun 2015 10:09:10 +0000
X-ASF-Spam-Status: No, hits=-2000.7 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Mon, 29 Jun 2015 10:07:00 +0000
Received: (qmail 12120 invoked by uid 99); 29 Jun 2015 10:08:47 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jun 2015 10:08:47 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 60377E1811; Mon, 29 Jun 2015 10:08:47 +0000 (UTC)
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-722-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-722-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Fix
 NodeJsWebAppFixtureIntegratio...
Content-Type: text/plain
Message-Id: <20150629100847.60377E1811@git1-us-west.apache.org>
Date: Mon, 29 Jun 2015 10:08:47 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/722#discussion_r33450066
  
    --- Diff: software/base/src/main/java/brooklyn/entity/java/JavaSoftwareProcessSshDriver.java ---
    @@ -336,7 +336,7 @@ protected int tryJavaInstall(String version, String command) {
             log.debug("Checking Java version at {}@{}", getEntity(), getLocation());
             // sed gets stdin like 'java version "1.7.0_45"'
             ProcessTaskWrapper<Integer> versionCommand = Entities.submit(getEntity(), SshTasks.newSshExecTaskFactory(
    -                getLocation(), "java -version 2>&1 | grep \"java version\" | sed 's/.*\"\\(.*\\).*\"/\\1/'"));
    +                getLocation(), "java -version 2>&1 | grep \" version\" | sed 's/.*\"\\(.*\\).*\"/\\1/'"));
    --- End diff --
    
    worth a comment on the reason for this change -- presumably some java gives different output?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---