Return-Path: 
 <dev-return-8126-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2119F187D3
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Wed, 24 Jun 2015 06:07:16 +0000 (UTC)
Received: (qmail 42652 invoked by uid 500); 24 Jun 2015 06:07:15 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 42627 invoked by uid 500); 24 Jun 2015 06:07:15 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 42391 invoked by uid 99); 24 Jun 2015 06:07:14 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2015 06:07:14 +0000
X-ASF-Spam-Status: No, hits=-2001.4 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Wed, 24 Jun 2015 06:05:04 +0000
Received: (qmail 39280 invoked by uid 99); 24 Jun 2015 06:06:51 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jun 2015 06:06:51 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 61080E091F; Wed, 24 Jun 2015 06:06:51 +0000 (UTC)
From: ahgittin <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-705-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-705-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Catalog default niceness
Content-Type: text/plain
Message-Id: <20150624060651.61080E091F@git1-us-west.apache.org>
Date: Wed, 24 Jun 2015 06:06:51 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/705#discussion_r33119484
  
    --- Diff: software/base/src/main/java/brooklyn/entity/software/StaticSensor.java ---
    @@ -36,9 +43,17 @@ public StaticSensor(ConfigBag params) {
             value = params.get(STATIC_VALUE);
         }
     
    +    @SuppressWarnings("unchecked")
         @Override
         public void apply(EntityLocal entity) {
             super.apply(entity);
    -        entity.setAttribute(sensor, (T) TypeCoercions.coerce(value, sensor.getType()));
    +        
    +        Maybe<T> v = Tasks.resolving(value).as((Class<T>)sensor.getType()).timeout(Duration.millis(200)).getMaybe();
    --- End diff --
    
    This is an important distinction which I don't think we make explicit.
    
    Config supports tasks/suppliers which are resolved whenever read.  Sensors are values published at a point in time so don't normally support resolution (except for this one).
    
    I've added javadoc:
    
    ```
    /** 
     * Provides an initializer/feed which simply sets a given value.
     * <p>
     * {@link Task}/{@link Supplier} values are resolved when written,
     * unlike config values which are resolved on each read.
     * <p>
     * This supports a {@link StaticSensor#SENSOR_PERIOD} 
     * which can be useful if the supplied value is such a function.
     * However when the source is another sensor,
     * consider using {@link Propagator} which listens for changes instead. */
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---