Return-Path: 
 <dev-return-7965-apmail-brooklyn-dev-archive=brooklyn.apache.org@brooklyn.incubator.apache.org>
X-Original-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Delivered-To: apmail-brooklyn-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2FCDB1848F
	for <apmail-brooklyn-dev-archive@minotaur.apache.org>;
 Fri, 19 Jun 2015 15:38:18 +0000 (UTC)
Received: (qmail 13668 invoked by uid 500); 19 Jun 2015 15:38:18 -0000
Delivered-To: apmail-brooklyn-dev-archive@brooklyn.apache.org
Received: (qmail 13632 invoked by uid 500); 19 Jun 2015 15:38:18 -0000
Mailing-List: contact dev-help@brooklyn.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@brooklyn.incubator.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@brooklyn.incubator.apache.org>
List-Post: <mailto:dev@brooklyn.incubator.apache.org>
List-Id: <dev.brooklyn.incubator.apache.org>
Reply-To: dev@brooklyn.incubator.apache.org
Delivered-To: mailing list dev@brooklyn.incubator.apache.org
Received: (qmail 13621 invoked by uid 99); 19 Jun 2015 15:38:17 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2015 15:38:17 +0000
X-ASF-Spam-Status: No, hits=-2000.4 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3)
    by apache.org (qpsmtpd/0.29) with SMTP; Fri, 19 Jun 2015 15:36:07 +0000
Received: (qmail 13250 invoked by uid 99); 19 Jun 2015 15:37:54 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jun 2015 15:37:54 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 448D9E041E; Fri, 19 Jun 2015 15:37:54 +0000 (UTC)
From: neykov <git@git.apache.org>
To: dev@brooklyn.incubator.apache.org
Reply-To: dev@brooklyn.incubator.apache.org
References: <git-pr-700-incubator-brooklyn@git.apache.org>
In-Reply-To: <git-pr-700-incubator-brooklyn@git.apache.org>
Subject: [GitHub] incubator-brooklyn pull request: Fix integration tests (core
 and s...
Content-Type: text/plain
Message-Id: <20150619153754.448D9E041E@git1-us-west.apache.org>
Date: Fri, 19 Jun 2015 15:37:54 +0000 (UTC)
X-Virus-Checked: Checked by ClamAV on apache.org

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/700#discussion_r32840547
  
    --- Diff: core/src/main/java/brooklyn/util/internal/ssh/ShellAbstractTool.java ---
    @@ -296,9 +296,10 @@ public ToolAbstractAsyncExecScript(Map<String,?> props) {
              * The executed command will return immediately, but the output from the script
              * will continue to be written 
              * note that some modes require \$RESULT passed in order to access a variable, whereas most just need $ */
    +        @Override
             protected List<String> buildRunScriptCommand() {
                 String touchCmd = String.format("touch %s %s %s %s", stdoutPath, stderrPath, exitStatusPath, pidPath);
    -            String cmd = String.format("( %s > %s 2> %s < /dev/null ; echo $? > %s ) & disown", scriptPath, stdoutPath, stderrPath, exitStatusPath);
    --- End diff --
    
    This command was working fine with the tests, but using `disown` while ending the ssh session doesn't seem right, so I converted it to use `nohup`. Any reason it shouldn't be changed? cc @aledsage 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---