brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rdowner <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Clarify operation of `templateOpt...
Date Wed, 24 Jun 2015 10:13:28 GMT
GitHub user rdowner opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/714

    Clarify operation of `templateOptions` config key

    Follow on for PR #639; that PR has not been merged, but it's only commit snuck into another
PR and has actually been merged. The intention of this PR is to address the review comments.
    
    Resolves the ambiguity around single parameters of type list. Extracts the bulk of the
code into a new standalone class and adds tests. Adds documentation.
    
    Tested with this blueprint:
    
    ```yaml
    location: AWS_eu-west-1
    services:
    - type: brooklyn.entity.basic.EmptySoftwareProcess
      provisioningProperties:
        templateOptions:
          subnetId: subnet-041c8373
          securityGroupIds: ['sg-4db68928']
          mapNewVolumeToDeviceName: ["/dev/sda1", 100, true]
    ```
    
    ...and verified that all three parameters (each of which exercise a different code path)
had been applied.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rdowner/incubator-brooklyn allow-list-in-templateOptions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/714.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #714
    
----
commit 8d95139d143826719239cf7e05b6159eb4ee5eac
Author: Richard Downer <richard@apache.org>
Date:   2015-06-24T09:58:11Z

    Clarify operation of `templateOptions` config key
    
    Resolves the ambiguity around single parameters of type list. Extracts
    the bulk of the code into a new standalone class and adds tests. Adds
    documentation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message