brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Ignore entity.addFeed(...) call w...
Date Mon, 22 Jun 2015 16:02:35 GMT
GitHub user neykov opened a pull request:

    https://github.com/apache/incubator-brooklyn/pull/708

    Ignore entity.addFeed(...) call with same feed object

    Adding the same feed object a second time would stop it, ignore the call instead. Adding
the same object twice is very common when `FEATURE_FEED_REGISTRATION_PROPERTY` is enabled,
because blueprints already add it manually.
    
    Fixes `NginxRebindWithHaIntegrationTest.testChangeModeFailureStopsTasksButHappyUponResumption`,
which enables `FEATURE_FEED_REGISTRATION_PROPERTY`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/neykov/incubator-brooklyn fix/integration-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-brooklyn/pull/708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #708
    
----
commit 90237c87b78c964e319fcf889a0ca4910b8d3c9d
Author: Svetoslav Neykov <svetoslav.neykov@cloudsoftcorp.com>
Date:   2015-06-22T15:54:04Z

    Ignore entity.addFeed(...) call with same feed object
    
    Adding the same feed object a second time would stop it, ignore the call instead. Adding
the same object twice is very common when FEATURE_FEED_REGISTRATION_PROPERTY is enabled, because
blueprints already add it manually.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message