brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BROOKLYN-149) Rebind failed when entity's catalog item not found
Date Mon, 08 Jun 2015 10:53:00 GMT


ASF GitHub Bot commented on BROOKLYN-149:

GitHub user aledsage opened a pull request:

    BROOKLYN-149: Partial fix for rebind when catalog missing


You can merge this pull request into a Git repository by running:

    $ git pull fix/rebind-when-catalog-missing

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #683
commit 52478ec9f7c056dc869f3f6b3fe3d499858a280c
Author: Aled Sage <>
Date:   2015-06-04T21:42:55Z

    Partial fix for BROOKLYN-149 (rebind when catalog deleted)
    - If entities etc still on classpath, then will continue with rebind.
      But if entities cannot be created, will still fail terminally.

commit 1c689909ff7ea92a218dbb03e9721e99507c54b9
Author: Aled Sage <>
Date:   2015-06-04T21:43:41Z

    Tidy warnings in RebindExceptionHandlerImpl
    - Previous warning (“returning null”) didn’t make sense when read in a
      log, out of the context of the individual method.


> Rebind failed when entity's catalog item not found
> --------------------------------------------------
>                 Key: BROOKLYN-149
>                 URL:
>             Project: Brooklyn
>          Issue Type: Bug
>    Affects Versions: 0.7.0-SNAPSHOT
>            Reporter: Aled Sage
>             Fix For: 0.7.0-SNAPSHOT
> A customer's Brooklyn instance failed to rebind on restart. The error was:
> {noformat}
> vcompose1476-compose-amp.console-v1.5.3.log:2015-05-15 06:57:12,808 ERROR Management
node zdJa2A7Y enountered problem during rebind when promoting self to master; demoting to
FAILED and rethrowing: brooklyn.util.exceptions.PropagatedRuntimeException: Failure rebinding,
71 errors including: problem creating ENTITY Ocs2eaWX of type brooklyn.entity.nosql.riak.RiakClusterImpl:
Failed to load catalog item OJ081XYKT_0=:1.0 required for rebinding.
> oklyn-Allow-Non-Master-Access' to force)
> {noformat}
> The full exception was:
> {noformat}
> 2015-05-15 06:40:31,369 WARN  b.e.r.RebindExceptionHandlerImpl [brooklyn-execmanager-boo0I83w-0]:
No catalog item found with id OJ081XYKT_0=:1.0; returning null
> 2015-05-15 06:40:31,395 WARN  b.e.r.RebindExceptionHandlerImpl [brooklyn-execmanager-boo0I83w-0]:
Rebind: continuing after problem creating ENTITY Ocs2eaWX of type brooklyn.entity.nosql.riak.RiakClusterImpl
> java.lang.IllegalStateException: Failed to load catalog item OJ081XYKT_0=:1.0 required
for rebinding.
>         at brooklyn.entity.rebind.RebindIteration$BrooklynObjectInstantiator.getLoadingContextFromCatalogItemId(
>         at brooklyn.entity.rebind.RebindIteration$BrooklynObjectInstantiator.load(
>         at brooklyn.entity.rebind.RebindIteration$BrooklynObjectInstantiator.newEntity(
>         at brooklyn.entity.rebind.RebindIteration.instantiateLocationsAndEntities(
>         at brooklyn.entity.rebind.RebindIteration.doRun( [brooklyn-core-0.7.0-20150509.1751.jar:0.7.0-20150509.1751]
>         at brooklyn.entity.rebind.InitialFullRebindIteration.doRun(
>         at [brooklyn-core-0.7.0-20150509.1751.jar:0.7.0-20150509.1751]
>         at brooklyn.entity.rebind.RebindManagerImpl.rebindImpl(
>         at brooklyn.entity.rebind.RebindManagerImpl$
>         at brooklyn.entity.rebind.RebindManagerImpl$
>         at brooklyn.util.task.BasicExecutionManager$
>         at [na:1.7.0_71]
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(
>         at java.util.concurrent.ThreadPoolExecutor$
>         at [na:1.7.0_71]
> {noformat}
> In the persisted state, there is no mention of the catalog item OJ081XYKT_0.
> My assumption is that the customer manually added a catalog item (via the web-console),
deployed an app (entitled "<snip> riak", of type RiakCluster), and then deleted the
catalog item (or that "deletion" could have been an issue with persistence of catalog items
- see
> The desired behaviour is that this does not cause the entire Brooklyn instance to fail
to rebind/start.
> ---
> There are several potential things to investigate/improve:
> * Test (manually, and then perhaps automated tests?):
>    * adding a catalog item (via web-console), deploying an app, and restarting AMP
>    * adding a catalog item (via web-console), deploying an app, deleting the catalog
item (but not the app), and restarting AMP
> * Investigate what catalog ids are used when adding through the web-console  
>   (or did they manually choose the name OJ081XYKT_0?)
> * Configurable for whether to continue startup onCreateFailed  
>   (e.g. web-console pops up with "there was an error..."), but can click continue.
> * Broolyn web-console to have a page showing all errors
>   * Support "quick fixes" such as deleting the item(s).

This message was sent by Atlassian JIRA

View raw message