brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BROOKLYN-137) Stop Iptables and open iptables don't work on centOS 7
Date Mon, 22 Jun 2015 10:22:00 GMT

    [ https://issues.apache.org/jira/browse/BROOKLYN-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595721#comment-14595721
] 

ASF GitHub Bot commented on BROOKLYN-137:
-----------------------------------------

Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/707#discussion_r32920648
  
    --- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java
---
    @@ -364,7 +364,15 @@ public boolean isWindows(NodeMetadata node, ConfigBag config) {
                     ? (OsFamily.WINDOWS == os.getFamily()) 
                     : (OsFamily.WINDOWS == confFamily);
         }
    -
    +    
    +    public boolean isNodeFirewalldEnabled(NodeMetadata node) {
    +        String OS = node.getOperatingSystem().getFamily().toString();
    +        String version = node.getOperatingSystem().getVersion();
    +        return node.getOperatingSystem().getVersion().startsWith("7") &&
    +             (node.getOperatingSystem().getFamily().equals(OsFamily.RHEL) ||
    +              node.getOperatingSystem().getFamily().equals(OsFamily.CENTOS));
    --- End diff --
    
    The check is not future proof. Instead of checking fixed OS versions is it possible to
check for the existence of firewall-cmd instead? This will allow the blueprint to work on
future versions of the OS without any changes. 


> Stop Iptables and open iptables don't work on centOS 7
> ------------------------------------------------------
>
>                 Key: BROOKLYN-137
>                 URL: https://issues.apache.org/jira/browse/BROOKLYN-137
>             Project: Brooklyn
>          Issue Type: Bug
>            Reporter: Andrea Turli
>            Assignee: Andrea Turli
>
> RHEL7 introduces firewalld as a replacement to iptables
> http://www.certdepot.net/rhel7-get-started-firewalld/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message