brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Heneveld <alex.henev...@cloudsoftcorp.com>
Subject Re: Vanilla Software Process - install.command support
Date Wed, 24 Jun 2015 16:18:16 GMT

Hi Thomas-

This feature (shell envs for more phases) went in to master this morning 
in as part of #705.

Best
Alex


On 24/06/2015 06:56, Thomas Bouron wrote:
> Hi Mike.
>
> Thanks for your PR, I'm playing with the new commands and it works like a
> charm! There is just one thing that seems broken: the environment variables
> defined by shell.env (or env) are not injected into the new phases install
> & customize. I checked the code but I cannot figure out why.
>
> Do you have any idea?
>
> For reference, here is a simple blueprint to verify what I'm talking about:
> ----------------------------------------------------------------------------------
> location: localhost
> services:
>    - type: brooklyn.entity.basic.VanillaSoftwareProcess
>      env:
>        HOST: $brooklyn.attributeWhenReady("host.address")
>      install.command: echo $HOST
>      customize.command: echo $HOST
>      launch.command: echo "Launch"
>      checkRunning.command: ""
>      stop.command: ""
>
>
> On Tue, 16 Jun 2015 at 22:35 Mike Zaccardo <mike.zaccardo@cloudsoftcorp.com>
> wrote:
>
>> PR is up for adding customize / install commands for Vanilla, as per my
>> discussion with Alex yesterday:
>> https://github.com/apache/incubator-brooklyn/pull/695
>>
>> Re: Thomas and the status code checks -- I'm not sure about the intended
>> behavior.  Rest of dev, WDYT?
>>
>> -Mike
>>
>> On Tue, Jun 16, 2015 at 5:42 AM, Thomas Bouron <
>> thomas.bouron@cloudsoftcorp.com> wrote:
>>
>>> Mike,
>>>
>>> As you want to work on that, I should share one last think I discovered
>>> yesterday. The (post|pre).(install|launch).command don't check the final
>>> status code, meaning that even if the script fails and returns something
>>> different than 0, Brooklyn will happily consume it without complaining.
>>>
>>> I don't know if it's an intending behaviour but it might be worth adding
>> a
>>> check there.
>>>
>>> On Mon, 15 Jun 2015 at 16:51 Mike Zaccardo <
>>> mike.zaccardo@cloudsoftcorp.com>
>>> wrote:
>>>
>>>> I am going to work on this addition.
>>>>
>>>> On Thu, Jun 11, 2015 at 6:39 AM, Alex Heneveld <
>>>> alex.heneveld@cloudsoftcorp.com> wrote:
>>>>
>>>>> This would be a great addition to Vanilla.
>>>>>
>>>>> --A
>>>>>
>>>>>
>>>>>
>>>>> On 11/06/2015 10:21, Thomas Bouron wrote:
>>>>>
>>>>>> In fact, I just realised that it's not only the install command that
>>> is
>>>>>> missing, they are few others not exposed:
>>>>>> - setup
>>>>>> - copy-install-resources
>>>>>> - customize
>>>>>> - copy-runtime-resources command
>>>>>>
>>>>>> On Wed, 10 Jun 2015 at 15:54 Mike Zaccardo <
>>>>>> mike.zaccardo@cloudsoftcorp.com>
>>>>>> wrote:
>>>>>>
>>>>>>   I've been thinking the same thing recently wrt my Artifactory
>>>> blueprints.
>>>>>>> Big bash scripts in launch that should probably not execute in
>>>> subsequent
>>>>>>> launches -- was going to move most of the initial actions to
a new
>>>>>>> command,
>>>>>>> so I'm very interested in this question as well.
>>>>>>>
>>>>>>> On Wed, Jun 10, 2015 at 10:48 AM, Thomas Bouron <
>>>>>>> thomas.bouron@cloudsoftcorp.com> wrote:
>>>>>>>
>>>>>>>   Hi there.
>>>>>>>> I'm currently developing a YAML blueprint that uses a Vanilla
>>> Software
>>>>>>>> Process with quite a long and complex launch.command bash
script.
>>> All
>>>> my
>>>>>>>> software installation - as well as the actual launch - is
>> contained
>>>>>>> within
>>>>>>>
>>>>>>>> this bash script.
>>>>>>>>
>>>>>>>> Now, I would like to leverage the fact that Brooklyn has
different
>>>> steps
>>>>>>>> like: install, customize, launch, etc. to avoid reinstalling
>>>> everything
>>>>>>>> when I hit the restart button on Brooklyn. Not to mention
that it
>>>> would
>>>>>>>> make sense to separate my script into two parts: one for
the
>> install
>>>>>>> itself
>>>>>>>
>>>>>>>> and one for the launch.
>>>>>>>>
>>>>>>>> I checked the config keys available (
>>>>>>>>
>>>>>>>>
>>>>>>>>
>> https://brooklyn.incubator.apache.org/learnmore/catalog/catalog-item.html#!entities/brooklyn.entity.basic.VanillaSoftwareProcess
>>>>>>>> )
>>>>>>>> and there is no install.command available, even though you
can
>>>> specify a
>>>>>>>> pre.install.command and post.install.command.
>>>>>>>>
>>>>>>>> Is there a good reason for that?
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>>
>>>>>>>> Best.
>>>>>>>>
>>>>>>>> --
>>>>>>>> Thomas
>>>>>>>>
>>>>>>>> --
>>>>>>>> Cloudsoft Corporation Limited, Registered in Scotland No:
>> SC349230.
>>>>>>>>    Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>>>>>>>>
>>>>>>>> This e-mail message is confidential and for use by the addressee
>>> only.
>>>>>>>> If
>>>>>>>> the message is received by anyone other than the addressee,
please
>>>>>>>> return
>>>>>>>> the message to the sender by replying to it and then delete
the
>>>> message
>>>>>>>> from your computer. Internet e-mails are not necessarily
secure.
>>>>>>>>
>>>>>>> Cloudsoft
>>>>>>>
>>>>>>>> Corporation Limited does not accept responsibility for changes
>> made
>>> to
>>>>>>> this
>>>>>>>
>>>>>>>> message after it was sent.
>>>>>>>>
>>>>>>>> Whilst all reasonable care has been taken to avoid the
>> transmission
>>> of
>>>>>>>> viruses, it is the responsibility of the recipient to ensure
that
>>> the
>>>>>>>> onward transmission, opening or use of this message and any
>>>> attachments
>>>>>>>> will not adversely affect its systems or data. No responsibility
>> is
>>>>>>>> accepted by Cloudsoft Corporation Limited in this regard
and the
>>>>>>>>
>>>>>>> recipient
>>>>>>>
>>>>>>>> should carry out such virus and other checks as it considers
>>>>>>>> appropriate.
>>>>>>>>
>>>>>>>>   --
>>>>>>> Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
>>>>>>>    Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>>>>>>>
>>>>>>> This e-mail message is confidential and for use by the addressee
>>> only.
>>>> If
>>>>>>> the message is received by anyone other than the addressee, please
>>>> return
>>>>>>> the message to the sender by replying to it and then delete the
>>> message
>>>>>>> from your computer. Internet e-mails are not necessarily secure.
>>>>>>> Cloudsoft
>>>>>>> Corporation Limited does not accept responsibility for changes
made
>>> to
>>>>>>> this
>>>>>>> message after it was sent.
>>>>>>>
>>>>>>> Whilst all reasonable care has been taken to avoid the transmission
>>> of
>>>>>>> viruses, it is the responsibility of the recipient to ensure
that
>> the
>>>>>>> onward transmission, opening or use of this message and any
>>> attachments
>>>>>>> will not adversely affect its systems or data. No responsibility
is
>>>>>>> accepted by Cloudsoft Corporation Limited in this regard and
the
>>>>>>> recipient
>>>>>>> should carry out such virus and other checks as it considers
>>>> appropriate.
>>>>>>>
>>>>> --
>>>>> Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
>>>>> Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>>>>>
>>>>> This e-mail message is confidential and for use by the addressee
>> only.
>>> If
>>>>> the message is received by anyone other than the addressee, please
>>> return
>>>>> the message to the sender by replying to it and then delete the
>> message
>>>>> from your computer. Internet e-mails are not necessarily secure.
>>>> Cloudsoft
>>>>> Corporation Limited does not accept responsibility for changes made
>> to
>>>> this
>>>>> message after it was sent.
>>>>>
>>>>> Whilst all reasonable care has been taken to avoid the transmission
>> of
>>>>> viruses, it is the responsibility of the recipient to ensure that the
>>>>> onward transmission, opening or use of this message and any
>> attachments
>>>>> will not adversely affect its systems or data. No responsibility is
>>>>> accepted by Cloudsoft Corporation Limited in this regard and the
>>>> recipient
>>>>> should carry out such virus and other checks as it considers
>>> appropriate.
>>>> --
>>>> Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
>>>>   Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>>>>
>>>> This e-mail message is confidential and for use by the addressee only.
>> If
>>>> the message is received by anyone other than the addressee, please
>> return
>>>> the message to the sender by replying to it and then delete the message
>>>> from your computer. Internet e-mails are not necessarily secure.
>>> Cloudsoft
>>>> Corporation Limited does not accept responsibility for changes made to
>>> this
>>>> message after it was sent.
>>>>
>>>> Whilst all reasonable care has been taken to avoid the transmission of
>>>> viruses, it is the responsibility of the recipient to ensure that the
>>>> onward transmission, opening or use of this message and any attachments
>>>> will not adversely affect its systems or data. No responsibility is
>>>> accepted by Cloudsoft Corporation Limited in this regard and the
>>> recipient
>>>> should carry out such virus and other checks as it considers
>> appropriate.
>>> --
>>> Thomas
>>>
>>> --
>>> Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
>>>   Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>>>
>>> This e-mail message is confidential and for use by the addressee only. If
>>> the message is received by anyone other than the addressee, please return
>>> the message to the sender by replying to it and then delete the message
>>> from your computer. Internet e-mails are not necessarily secure.
>> Cloudsoft
>>> Corporation Limited does not accept responsibility for changes made to
>> this
>>> message after it was sent.
>>>
>>> Whilst all reasonable care has been taken to avoid the transmission of
>>> viruses, it is the responsibility of the recipient to ensure that the
>>> onward transmission, opening or use of this message and any attachments
>>> will not adversely affect its systems or data. No responsibility is
>>> accepted by Cloudsoft Corporation Limited in this regard and the
>> recipient
>>> should carry out such virus and other checks as it considers appropriate.
>>>
>> --
>> Cloudsoft Corporation Limited, Registered in Scotland No: SC349230.
>>   Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
>>
>> This e-mail message is confidential and for use by the addressee only. If
>> the message is received by anyone other than the addressee, please return
>> the message to the sender by replying to it and then delete the message
>> from your computer. Internet e-mails are not necessarily secure. Cloudsoft
>> Corporation Limited does not accept responsibility for changes made to this
>> message after it was sent.
>>
>> Whilst all reasonable care has been taken to avoid the transmission of
>> viruses, it is the responsibility of the recipient to ensure that the
>> onward transmission, opening or use of this message and any attachments
>> will not adversely affect its systems or data. No responsibility is
>> accepted by Cloudsoft Corporation Limited in this regard and the recipient
>> should carry out such virus and other checks as it considers appropriate.
>>


-- 
Cloudsoft Corporation Limited, Registered in Scotland No: SC349230. 
 Registered Office: 13 Dryden Place, Edinburgh, EH9 1RP
 
This e-mail message is confidential and for use by the addressee only. If 
the message is received by anyone other than the addressee, please return 
the message to the sender by replying to it and then delete the message 
from your computer. Internet e-mails are not necessarily secure. Cloudsoft 
Corporation Limited does not accept responsibility for changes made to this 
message after it was sent.

Whilst all reasonable care has been taken to avoid the transmission of 
viruses, it is the responsibility of the recipient to ensure that the 
onward transmission, opening or use of this message and any attachments 
will not adversely affect its systems or data. No responsibility is 
accepted by Cloudsoft Corporation Limited in this regard and the recipient 
should carry out such virus and other checks as it considers appropriate.

Mime
View raw message