brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ahgittin <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fixes issue where port was not be...
Date Fri, 26 Jun 2015 11:16:42 GMT
Github user ahgittin commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/717#issuecomment-115650032
  
    @nakomis @neykov why not just   `TypeCoercions(getRaw(PORT_KEY), PortRange.class)` ?
    
    this should convert `int` to `PortRange` and then iterate, which might be slightly wasteful
but worth it as it's simpler.
    
    also @nakomis note uses of `Tasks.resolving(...)` -- resolving config is normally non-blocking
but if blocking is a problem you can do `Tasks.resolving(<raw config>).timeout(ValueResolver.REAL_QUICK_WAIT)...`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message