brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nakomis <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fixes issue where port was not be...
Date Fri, 26 Jun 2015 08:37:04 GMT
Github user nakomis commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/717#issuecomment-115575034
  
    Using `http.port: 9999+` in the YAML (akin to using `entity.configure("http.port", "9999+")`
as opposed to `entity.configure(Attributes.HTTP_PORT, "9999+")`, like I used in the unit test
that I added) will create a `ConfigKey<Object>` and the previous implementation did
recognise it as a port range. To determine that it is a port range, you must either resolve
the value (which causes the thread to hang if any of them are futures etc, breaking `SoftwareProcessEntityLatchTest`),
or use `getRaw`
    
    I'd intended to update `SameServerDriverLifecycleEffectorTasks` to use `getRaw`, but overlooked
that. If you agree the right approach is to use `getRaw`, I'll update `SameServerDriverLifecycleEffectorTasks`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message