brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Fixes issue where port was not be...
Date Thu, 25 Jun 2015 15:21:18 GMT
Github user neykov commented on the pull request:

    https://github.com/apache/incubator-brooklyn/pull/717#issuecomment-115290661
  
    The previous implementation had better behaviour where it would resolve only port config
keys. You can keep the old behaviour, while introducing a new case where the value is `PortRange`
and doesn't need resolving. Also for the case where the value is already available, but wrapped
in a future, you can use ValueResolver with a 0 timeout.
    
    Also the `SameServerDriverLifecycleEffectorTasks` doesn't use `getRaw`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message