brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <>
Subject [GitHub] incubator-brooklyn pull request: Catalog default niceness
Date Wed, 24 Jun 2015 12:54:10 GMT
Github user neykov commented on a diff in the pull request:
    --- Diff: core/src/main/java/brooklyn/enricher/basic/ ---
    @@ -24,25 +24,20 @@
     import org.slf4j.LoggerFactory;
     import brooklyn.config.ConfigKey;
    -import brooklyn.entity.Entity;
     import brooklyn.entity.basic.ConfigKeys;
    -import brooklyn.entity.basic.EntityLocal;
    -import brooklyn.event.AttributeSensor;
    -import brooklyn.event.Sensor;
     import brooklyn.event.SensorEvent;
    -import brooklyn.event.SensorEventListener;
    -import brooklyn.event.basic.BasicSensorEvent;
     import brooklyn.util.collections.MutableSet;
     import brooklyn.util.task.Tasks;
    -import brooklyn.util.time.Duration;
    +import brooklyn.util.task.ValueResolver;
     //@Catalog(name="Transformer", description="Transforms attributes of an entity; see Enrichers.builder().transforming(...)")
    -public class Transformer<T,U> extends AbstractEnricher implements SensorEventListener<T>
    +public class Transformer<T,U> extends AbstractTransformer<T,U> {
    +    @SuppressWarnings("unused")
    --- End diff --
    What's the point of keeping the logger, better delete it.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message