brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From neykov <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: Catalog default niceness
Date Tue, 23 Jun 2015 15:17:35 GMT
Github user neykov commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/705#discussion_r33052674
  
    --- Diff: software/base/src/main/java/brooklyn/entity/software/StaticSensor.java ---
    @@ -36,9 +43,17 @@ public StaticSensor(ConfigBag params) {
             value = params.get(STATIC_VALUE);
         }
     
    +    @SuppressWarnings("unchecked")
         @Override
         public void apply(EntityLocal entity) {
             super.apply(entity);
    -        entity.setAttribute(sensor, (T) TypeCoercions.coerce(value, sensor.getType()));
    +        
    +        Maybe<T> v = Tasks.resolving(value).as((Class<T>)sensor.getType()).timeout(Duration.millis(200)).getMaybe();
    --- End diff --
    
    Why not set the raw value and resolve & coerce at read time?
    
    The resolve timeouts seem to be arbitrarily chosen - I've seen 50ms at other places. Better
use a global constant instead?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message