brooklyn-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From robertgmoss <...@git.apache.org>
Subject [GitHub] incubator-brooklyn pull request: clean up how locations are render...
Date Tue, 23 Jun 2015 11:28:54 GMT
Github user robertgmoss commented on a diff in the pull request:

    https://github.com/apache/incubator-brooklyn/pull/704#discussion_r33031624
  
    --- Diff: core/src/main/java/brooklyn/catalog/internal/BasicBrooklynCatalog.java ---
    @@ -355,6 +355,10 @@ public void load() {
                     default: throw new RuntimeException("Only entity, policy & location
catalog items are supported. Unsupported catalog item type " + item.getCatalogItemType());
                 }
                 ((AbstractBrooklynObjectSpec<?, ?>)spec).catalogItemId(item.getId());
    +            
    +            if (Strings.isBlank( ((AbstractBrooklynObjectSpec<?, ?>)spec).getDisplayName()
))
    +                ((AbstractBrooklynObjectSpec<?, ?>)spec).displayName(item.getDisplayName());
    --- End diff --
    
    Would be nicer to see this cast only once


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message